Re: Insufficient locking for ALTER DEFAULT PRIVILEGES

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Vik Fearing <vik(at)2ndquadrant(dot)fr>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Insufficient locking for ALTER DEFAULT PRIVILEGES
Date: 2015-06-23 13:49:53
Message-ID: CA+TgmoYF-3vxRbMXXWP4aXRv2U+x5AWiKFCftm_cM8L7hf7Sdw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jun 21, 2015 at 11:11 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2015-06-21 11:45:24 -0300, Alvaro Herrera wrote:
>> Alvaro Herrera wrote:
>> > Now that I actually check with a non-relation object, I see pretty much
>> > the same error. So probably if instead of some narrow bug fix what we
>> > need is some general solution for all object types. I know this has
>> > been discussed a number of times ... Anyway I see now that we should
>> > not consider this a backpatchable bug fix, and I'm not doing the coding
>> > either, at least not now.
>>
>> Discussed this with a couple of 2ndQ colleagues and it became evident
>> that MVCC catalog scans probably make this problem much more prominent.
>> So historical branches are not affected all that much, but it's a real
>> issue on 9.4+.
>
> Hm. I don't see how those would make a marked difference. The snapshot
> for catalogs scan are taken afresh for each scan (unless
> cached). There'll probably be some difference, but it'll be small.

Yeah, I think the same. If those changes introduced a problem we
didn't have before, I'd like to see a reproducible test case.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2015-06-23 14:03:43 Re: pg_rewind failure by file deletion in source server
Previous Message Robert Haas 2015-06-23 13:48:15 Re: Memory context at PG_init call ?