| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Lukas Fittl <lukas(at)fittl(dot)com>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Dian Fay <di(at)nmfay(dot)com>, Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_plan_advice |
| Date: | 2026-01-29 13:33:13 |
| Message-ID: | CA+TgmoYEz=ef3-djP-F0SVbOCyPYy6smrhuFBgnNwBNx8UyJpQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 28, 2026 at 6:41 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
> Just noticed this in the committed patch, it doesn't seem intentional:
> (the last line wasn't part of the patch, probably an accidental leftover)
>
> src/backend/optimizer/ptah/costsize.c:1462
>
> if (path->parallel_workers == 0)
> enable_mask |= PGS_CONSIDER_NONPARTIAL;
> path->disabled_nodes =
> (baserel->pgs_mask & enable_mask) != enable_mask ? 1 : 0;
> path->disabled_nodes = 0;
Good catch. I have included a fix for this in
4020b370f214315b8c10430301898ac21658143f.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-01-29 13:34:25 | Re: pg_plan_advice |
| Previous Message | Matheus Alcantara | 2026-01-29 13:32:04 | Re: [PATCH] llvmjit: always add the simplifycfg pass |