| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Oskari Saarenmaa <os(at)ohmu(dot)fi> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: __attribute__ for non-gcc compilers |
| Date: | 2015-02-23 02:31:46 |
| Message-ID: | CA+TgmoYEcz9G9CBd4E05bWPZ=OxiySL8SX6OD_MXwBwunmbq-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 17, 2015 at 8:41 AM, Oskari Saarenmaa <os(at)ohmu(dot)fi> wrote:
> 15.01.2015, 21:58, Robert Haas kirjoitti:
>> On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>>> I think I'd for now simply not define pg_attribute_aligned() on
>>> platforms where it's not supported, instead of defining it empty. If we
>>> need a softer variant we can name it pg_attribute_aligned_if_possible or
>>> something.
>>>
>>> Sounds sane?
>>
>> Yes, that sounds like a much better plan.
>
> Attached an updated patch rebased on today's git master that never
> defines aligned or packed empty.
>
> This is also included in the current commitfest,
> https://commitfest.postgresql.org/4/115/
Is this going to play nicely with pgindent?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2015-02-23 02:32:18 | Re: a fast bloat measurement tool (was Re: Measuring relation free space) |
| Previous Message | Robert Haas | 2015-02-23 02:24:56 | Re: Redesigning checkpoint_segments |