Re: ThisTimeLineID can be used uninitialized

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: amul sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ThisTimeLineID can be used uninitialized
Date: 2021-10-25 15:03:57
Message-ID: CA+TgmoYD3FqgJ6xf15gYCH+Ui7bndXhAkE9oUQWf4fTa=7ASEw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 21, 2021 at 3:29 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I think the correct fix for this particular problem is just to delete
> the initialization, as in the attached patch. I spent a long time
> studying this today and eventually convinced myself that there's just
> no way these initializations can ever do anything (details in proposed
> commit message). While it is important that we do not access the
> global variable when it's uninitialized, here there is no reason to
> access it in the first place.

I have committed this.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-10-25 15:05:22 Re: pg_dump versus ancient server versions
Previous Message Tom Lane 2021-10-25 15:00:42 Re: pg_dump versus ancient server versions