From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, John W Higgins <wishdev(at)gmail(dot)com>, pgsql-hackers list <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Have I found an interval arithmetic bug? |
Date: | 2021-07-30 19:47:53 |
Message-ID: | CA+TgmoYAdZgreJTpEhzE-QS59iVMZkTjLY+2Da63K6-C8uuAJw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
On Fri, Jul 30, 2021 at 3:20 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Uh, what do you suggest then? You wanted the years/months fixed, and
> rounding at spill stop time makes sense, and fixes the problem.
Hmm, maybe I misunderstood. Are you saying that you think the patch
will fix cases like interval '-1.7 years 29.4 months' and interval
'29.4 months -1.7 years' to produce the same answer without changing
any other cases? I had the impression that you were proposing a bigger
change to the rules for converting fractional units to units of lower
type, particularly because Tom called it an "API change".
For some reason I can't apply the patch locally.
[rhaas pgsql]$ patch -p1 < ~/Downloads/interval.diff
(Stripping trailing CRs from patch.)
patching file doc/src/sgml/datatype.sgml
(Stripping trailing CRs from patch.)
patching file src/backend/utils/adt/datetime.c
patch: **** malformed patch at line 90: @@ -3601,7 +3597,7 @@
DecodeISO8601Interval(char *str,
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-07-30 19:54:42 | Re: Have I found an interval arithmetic bug? |
Previous Message | Dhanush D | 2021-07-30 19:22:15 | Postgres 9.6 to 12.7 pg_upgrade error - terminating connection due to administrator command |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2021-07-30 19:48:26 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
Previous Message | Melanie Plageman | 2021-07-30 19:35:30 | Re: Asynchronous and "direct" IO support for PostgreSQL. |