| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Add new function dsa_allocate0. |
| Date: | 2017-02-19 08:34:46 |
| Message-ID: | CA+TgmoYAbYZYPfQuS4uE6ig-hLp3uUR_ZyscZaBsmsnLyFVf_w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Feb 18, 2017 at 6:31 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>> Agreed. Here's a patch like that.
>
> Oops, that had a typo in a comment. Here's a better one.
This looked fine, except that the new comment in dsa_allocate
contained an extremely long sentence which happened to contradict the
last sentence of the existing comment. Committed after frobbing the
comment to fix those two issues.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-19 10:29:34 | pgsql: Add optimizer and executor support for parallel index-only scans |
| Previous Message | Robert Haas | 2017-02-19 08:34:35 | pgsql: Make dsa_allocate interface more like MemoryContextAlloc. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Devrim Gündüz | 2017-02-19 08:42:20 | Re: drop support for Python 2.3 |
| Previous Message | Robins Tharakan | 2017-02-19 06:02:25 | Re: Allow pg_dumpall to work without pg_authid |