Re: Spinlocks and compiler/memory barriers

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Spinlocks and compiler/memory barriers
Date: 2014-09-09 17:52:40
Message-ID: CA+TgmoY9_gFyr0r9M405QTxkgqv07Yv-hwGy+q_hfgdn10S5CA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 8, 2014 at 7:10 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> This has been pending for almost two months now and, at your request,
>> my patch to make spinlocks act as compiler barriers is waiting behind
>> it. Can we please get this moving again soon, or can I commit that
>> patch and you can fix this when you get around to it?
>
> I finally pushed this. And once more I seriously got pissed at the poor
> overall worldwide state of documentation and continously changing
> terminology around this.

There does seem to be a deficit in that area.

> Sorry for taking this long :(
>
> Do you have a current version of your patch to make them compiler
> barriers?

I had forgotten that it needed an update. Thanks for the reminder. Here's v2.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
spinlock-barrier-rmh-v2.patch text/x-patch 6.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-09-09 18:19:57 Re: posix_fadvise() and pg_receivexlog
Previous Message Petr Jelinek 2014-09-09 17:18:49 Re: pg_background (and more parallelism infrastructure patches)