Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: KONDO Mitsumasa <kondo(dot)mitsumasa(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Peter Geoghegan <pg(at)heroku(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me
Date: 2014-01-28 02:40:38
Message-ID: CA+TgmoY9U7K=yks0md6qQnL+55w3WsguNnPWAkadykdd93JKfQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Jan 27, 2014 at 9:31 PM, KONDO Mitsumasa
<kondo(dot)mitsumasa(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Why is your concern with pg_stat_statements after this patch in
>> particular?
>>
>> You'll need to serialize the file at least once before seeing it, but
>> then it's there for good (on old versions, before Magnus got annoyed
>> that that affected basebackups).
>
> I feel the sense of incongruity that is stored database data in text file.
> I'd like to hear from other people...

OK, I'll bite: I have no idea why you think that's a problem. The
entire database is stored in a bunch of files in the same directory
tree as that text file. If somebody can read the text file, they can
probably also read the entire contents of the database. Sure, the
actual relations are binary data rather than *text* files, but if you
can read them, you can *most definitely* extract the whole database
contents, which is several orders of magnitude worse than anything you
can do with pg_stat_statements.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2014-01-28 02:50:34 Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me
Previous Message Peter Geoghegan 2014-01-28 02:33:11 Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-01-28 02:41:23 Re: Freezing without write I/O
Previous Message Peter Geoghegan 2014-01-28 02:33:11 Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me