| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fabrízio Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Marko Kreen <markokr(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Adrian Klaver <adrian(dot)klaver(at)gmail(dot)com>, Nigel Heron <nigel(at)psycode(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [GENERAL] currval and DISCARD ALL |
| Date: | 2013-04-19 14:12:02 |
| Message-ID: | CA+TgmoY9+LAbpvGJYCvx4VOeffHgBjig2KkMYXeVWEsz2QXf9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On Fri, Apr 19, 2013 at 10:05 AM, Fabrízio de Royes Mello
<fabriziomello(at)gmail(dot)com> wrote:
> The attached wip patch do that and introduce a subcommand 'SEQUENCES', but
> if we decide to don't add a new subcommand to DISCARD, then its easier to
> modify the patch.
This patch is quite wrong. It frees seqtab without clearing the
pointer, so the next reference will stomp on memory that may have been
reallocated. And it doesn't even free seqtab correctly, since it only
frees the first node in the linked list.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrian Klaver | 2013-04-19 14:14:55 | Re: [GENERAL] currval and DISCARD ALL |
| Previous Message | Fabrízio de Royes Mello | 2013-04-19 14:05:36 | Re: [GENERAL] currval and DISCARD ALL |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-04-19 14:14:00 | Re: elog() error, trying CURENT OF with foreign table |
| Previous Message | Peter Eisentraut | 2013-04-19 14:11:41 | Re: event trigger API documentation? |