| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | Lukas Fittl <lukas(at)fittl(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_plan_advice |
| Date: | 2026-03-27 14:20:30 |
| Message-ID: | CA+TgmoY79RwaFyXpcMvniLUSKbC19mYpr9pXy8inuDZCzagk4A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 26, 2026 at 7:21 PM Mark Dilger
<mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> Then every single query that triggers advice collection will:
> 1. Successfully allocate an advice entry from existing free space
> 2. Enter store_shared_advice, hit the same chunk boundary
> 3. Fail to allocate the chunk
> 4. Leak the advice entry
> 5. Reduce remaining free space in the small size classes
Yeah, that's a leak. I just got through trying to harden
pg_stash_advice so that kind of thing can't happen, but I failed to
realize that pg_collect_advice has a version of the same issue.
Thanks,
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-03-27 14:29:00 | Re: Thread-safe getopt() |
| Previous Message | Peter Eisentraut | 2026-03-27 14:13:36 | Re: Windows meson build |