| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Erik Rijkers <er(at)xs4all(dot)nl>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: Declarative partitioning - another take |
| Date: | 2016-12-21 16:50:24 |
| Message-ID: | CA+TgmoY741D4MHhzSDgqc1=Jb2EF0sWba1Rqv2Rmo0-V9iSZQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 21, 2016 at 5:33 AM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Breaking changes into multiple commits/patches does not seem to work for
> adding regression tests. So, I've combined multiple patches into a single
> patch which is now patch 0002 in the attached set of patches.
Ugh, seriously? It's fine to combine closely related bug fixes but
not all of these are. I don't see why you can't add some regression
tests in one patch and then add some more in the next patch.
Meanwhile, committed the latest 0001 and the elog() patch.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-12-21 16:55:00 | Re: multi-level partitions and partition-wise joins |
| Previous Message | Tom Lane | 2016-12-21 16:49:25 | Getting rid of "unknown error" in dblink and postgres_fdw |