Re: Why clearing the VM doesn't require registering vm buffer in wal record

On Tue, Jun 23, 2026 at 7:55 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
> I've done this in attached v3. I've only included proposed changes to
> 18, as this ended up being a pretty invasive refactor that I'd like to
> get feedback on first.

I'm finding that these patches don't apply cleanly to the latest sources.

[robert.haas pgsql]$ git log -n1 --oneline
4df5fe3833a (HEAD -> master, origin/master, origin/HEAD) Make
crosstabview honor boolean/null display settings
[robert.haas pgsql]$ patch -p1 <
~/Downloads/v3-0001-Alias-WAL-block-references-for-some-record-types.patch
patching file 'src/backend/access/heap/heapam.c'
1 out of 10 hunks failed--saving rejects to
'src/backend/access/heap/heapam.c.rej'
patching file 'src/backend/access/heap/heapam_xlog.c'
1 out of 16 hunks failed--saving rejects to
'src/backend/access/heap/heapam_xlog.c.rej'
patching file 'src/include/access/heapam_xlog.h'

Apparently these patches are based on an old commit, or you have some
other local patches. Can you specify a commit to apply them to, and/or
rebase?

--
Robert Haas
EDB: http://www.enterprisedb.com