| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ian Barwick <ian(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Testing DDL deparsing support |
| Date: | 2014-12-08 17:43:36 |
| Message-ID: | CA+TgmoY1iscoj6BbM0Vf-4QrxEoEnLYKpW23OysTd4ZfqCqmqw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Dec 6, 2014 at 10:43 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> This causes creation DDL is checked if it is used in the regression
> database, but what about ALTER and DROP? pg_dump doesn't issue those,
> except in special cases like inheritance.
The proposed testing mechanism should cover any ALTER commands that
are in the regression tests provided that those objects are not
subsequently dropped -- because if the ALTER commands aren't replayed
properly, then the later pg_dump won't produce the same output.
There probably are some gaps in our current regression tests in this
area, but that's probably a good thing to fix regardless of this.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2014-12-08 17:43:57 | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Previous Message | Robert Haas | 2014-12-08 17:39:45 | Re: alter user set local_preload_libraries. |