Re: walsender doesn't send keepalives when writes are pending

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: walsender doesn't send keepalives when writes are pending
Date: 2014-02-25 16:15:46
Message-ID: CA+TgmoY=uNPzicCxLgXDZ5Hzo41Z9EybjtNGmEF=GeOd+6CfOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 25, 2014 at 10:54 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> I am not sure I can follow. Why doesn't it make sense to send out the
> keepalive (with replyRequested = true) when we're busy sending stuff
> (which will be the case most of the time on a busy server)?

It may very well make sense, but your patch won't generally have that
effect, because with the patch you proposed, the keep-alive can only
be sent when the server is busy if the write queue is also full.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-02-25 16:23:02 Re: walsender doesn't send keepalives when writes are pending
Previous Message Robert Haas 2014-02-25 16:13:16 Re: jsonb and nested hstore