Re: Dry-run mode for pg_archivecleanup

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Cc: Gabriele Bartolini <gabriele(dot)bartolini(at)2ndquadrant(dot)it>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Dry-run mode for pg_archivecleanup
Date: 2012-01-27 14:47:54
Message-ID: CA+TgmoY+3MdkwT_oPYF4pxszyTt3tBg7QneznnLL9vV0FEZ3aw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 15, 2012 at 5:05 PM, Josh Kupershmidt <schmiddy(at)gmail(dot)com> wrote:
> On Sun, Jan 15, 2012 at 3:02 PM, Gabriele Bartolini
> <gabriele(dot)bartolini(at)2ndquadrant(dot)it> wrote:
>
>> My actual intention was to have the filename as output of the command, in
>> order to easily "pipe" it to another script. Hence my first choice was to
>> use the stdout channel, considering also that pg_archivecleanup in dry-run
>> mode is harmless and does not touch the content of the directory.
>
> Oh, right - I should have re-read your initial email before diving
> into the patch. That all makes sense given your intended purpose. I
> guess your goal of constructing some simple way to pass the files
> which would be removed on to another script is a little different than
> what I initially thought the patch would be useful for, namely as a
> testing/debugging aid for an admin.
>
> Perhaps both goals could be met by making use of '--debug' together
> with '--dry-run'. If they are both on, then an additional message like
> "pg_archivecleanup: would remove file ... " would be printed to
> stderr, along with just the filename printed to stdout you already
> have.

This email thread seems to have trailed off without reaching a
conclusion. The patch is marked as Waiting on Author in the
CommitFest application, but I'm not sure that's accurate. Can we try
to nail this down?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-01-27 14:49:10 Re: Caching for stable expressions with constant arguments v6
Previous Message Robert Haas 2012-01-27 14:37:37 Re: Progress on fast path sorting, btree index creation time