| From: | Yurii Rashkovskii <yrashk(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name |
| Date: | 2023-07-02 23:37:52 |
| Message-ID: | CA+RLCQyBKNsqmumxMkFx_Fvr6bGKnmY8sxywAnxmyqPxix7tsg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Nathan,
On Fri, Jun 30, 2023 at 2:39 PM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:
>
> In v4, I've introduced a new BGW_LIBLEN macro and set it to the default
> value of MAXPGPATH (1024). This way, the value can live in bgworker.h like
> the other BGW_* macros do. Plus, this should make the assertion that
> checks for backward compatibility unnecessary. Since bgw_library_name is
> essentially a path, I can see the argument that we should just set
> BGW_LIBLEN to MAXPGPATH directly. I'm curious what folks think about this.
>
Thank you for revising the patch. While this is relatively minor, I think
it should be set to MAXPGPATH directly to clarify their relationship.
--
Y.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2023-07-03 00:09:48 | Re: Making empty Bitmapsets always be NULL |
| Previous Message | Thomas Munro | 2023-07-02 23:32:07 | Re: possible bug in handling of contrecords in dd38ff28ad (Fix recovery_prefetch with low maintenance_io_concurrency) |