Re: [Patch] Fix pg_get_multixact_stats() over-reporting members on a hot standby

From: Naga Appani <nagnrik(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Noah Misch <noah(at)leadboat(dot)com>
Subject: Re: [Patch] Fix pg_get_multixact_stats() over-reporting members on a hot standby
Date: 2026-09-24 02:40:48
Message-ID: CA+QeY+Duj7R7pCfXzmvJbAoKcwq41kvVp-wK2FRTfygA4EvVPw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 23, 2026 at 7:06 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Sep 21, 2026 at 10:55:02AM -0500, Naga Appani wrote:
> > I lean toward ERROR over NULL, but not strongly.
>
> I'll go switch that to an error if called while RecoveryInProgress(),
> then. Bonus points regarding the fact that we can reuse some of the
> existing error messages from xlogfuncs.c, meaning no extra translation
> required.
> --
> Michael
Thanks Michael, that matches what I had in v2 as well (same
errmsg/errhint pattern from xlogfuncs.c).

Thanks,
Naga

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Ajin Cherian 2026-09-24 02:40:12 Re: table-write trigger can bypass ATPrepChangePersistence