Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11
Date: 2018-06-29 13:26:36
Message-ID: CA+OCxozxjz+m=zy_AN4QPQtNHKuYTpQ6YpihoS=ugpzLe_jvEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi Hackers,
>
> Attached is the patch to fix the RM #3397 Add support for JIT stats in
> EXPLAIN output in PG11. Please review it.
>

A couple of immediate thoughts:

- When the canvas is first rendered, there's a vertical scrollbar now. As
soon as I mouseover the new icon, it vanishes and the icon jumps to the
right.

- The icon seems lighter than the other controls on the left.

- The icon isn't disabled when there is no info to show.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-06-29 13:37:08 pgAdmin 4 commit: Prep 3.2 release notes page.
Previous Message Aditya Toshniwal 2018-06-29 11:16:33 Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters