From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Chris Mayo <aklhfex(at)gmail(dot)com> |
Cc: | "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Document that a patch should be submitted to the list as an attachment |
Date: | 2016-10-11 14:34:54 |
Message-ID: | CA+OCxozwteHaoa9ge5n2WXu9SgF71cn8Z118a5E2JEaNP0yBTw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Monday, October 10, 2016, Chris Mayo <aklhfex(at)gmail(dot)com> wrote:
> Signed-off-by: Chris Mayo <aklhfex(at)gmail(dot)com <javascript:;>>
> ---
> docs/en_US/submitting_patches.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>
This doesn't apply - can you rebase it please?
Thanks.
(pgadmin4)snake:pgadmin4 dpage$ git apply
~/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch
/Users/dpage/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch:13:
trailing whitespace.
the chances of it being rejected. Once you're happy with your work, mail it
/Users/dpage/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch:14:
trailing whitespace.
as an attachment to the mailing list pgadmin-hackers(at)postgresql(dot)org(dot)
/Users/dpage/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch:15:
trailing whitespace.
Please ensure you include a full description of what the patch does,
/Users/dpage/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch:16:
trailing whitespace.
as well as the rationale for any important design decisions.
error: patch failed: docs/en_US/submitting_patches.rst:30
error: docs/en_US/submitting_patches.rst: patch does not apply
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-10-11 15:40:30 | RM1849: Auto-generating security keys |
Previous Message | Dave Page | 2016-10-11 04:44:16 | Running pgadmin4 as desktop application |