Re: pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

From: Dave Page <dpage(at)postgresql(dot)org>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.
Date: 2016-10-24 09:33:49
Message-ID: CA+OCxozh_8+m95v9q=X8hrTXUGJe+7WJuZHZ1yLYMG3fYkT8hQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi

On Sun, Oct 23, 2016 at 8:22 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> On 10/22/2016 07:11 PM, Tom Lane wrote:
>>
>> I wrote:
>>>
>>> The only other Windows machines in the buildfarm that are building
>>> with openssl are Andrew's bowerbird and frogmouth; they're both passing.
>>> I wonder what openssl version is on those.
>>
>>
>> What's the plan for getting the buildfarm back to green in the wake
>> of this patch? If there isn't one, I'd like to request that the patch
>> be reverted until such time as some effort can be put into it. Right
>> now, these failures are preventing us from telling whether the recent
>> postgres_fdw changes will pass everywhere.
>
>
> Dave, what are we going to do about this? I cannot reproduce a similar
> breakage on my system with OpenSSL 0.9.8 versions, and I don't have access
> to the boxes themselves, so I'm pretty much stuck in trying to debug the
> issue. And I wouldn't like to spend much time on that anyway, given that the
> OpenSSL versions they use are ancient, and all other buildfarm animals are
> happy.

As I mentioned earlier in the thread, I couldn't get a modern version
to configure at all on there.

> Any chance you could update the OpenSSL versions on those systems, or
> failing that, remove --with-openssl?

Well I could. But really, how useful is that given that it's got to be
pretty rare that people won't use OpenSSL in a build? Those machines
are so old now that I don't think there's any merit in keeping them is
there?

--
Dave Page
PostgreSQL Core Team
http://www.postgresql.org/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2016-10-24 11:30:23 Re: pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.
Previous Message Fabien COELHO 2016-10-24 06:36:55 Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list