From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Added Node Type & Catalog objects [pgAdmin4] |
Date: | 2016-03-18 16:52:45 |
Message-ID: | CA+OCxoz_rEVOMa1nfJxH16-ZB6YXozm-DAAV8HOE5EORqAwQLQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Fri, Mar 18, 2016 at 7:15 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Even after installing PosGIS I’m not able to create new custom external type
> because the SQL does not return any value (Same behaviour as is in pgAdmin3)
> , But I’m able to list all of it’s properties of external types same as
> pgAdmin3 (PFA screenshots).
Hmm, I wonder if that's a pgAdmin 3 bug. Please check the CREATE TYPE
docs, and make sure the queries we're using are appropriate to find
suitable functions. It's possible we've messed that up.
> I have also attached patch for plain fields control (without lable & border)
> for backform. (Please apply it before testing new type patch)
That looks better. I'll commit that patch.
> - I'm allowed to edit ENUM label names, but PostgreSQL doesn't support that.
This issue still exists.
I also noticed some weirdness with the error message display - please
see the attached screenshots. The one complaining about the missing
name is as I'd expect. The second one is showing the error message an
additional time. Please look at that.
I've attached an updated patch - I cleaned up some strings and
localisation tags in this version.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
![]() |
image/png | 71.9 KB |
![]() |
image/png | 63.5 KB |
types_node_v4-dave.patch | application/octet-stream | 106.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-03-18 16:54:54 | pgAdmin 4 commit: Add support for inline fieldsets. |
Previous Message | Dave Page | 2016-03-18 16:07:14 | Re: Control for selecting multiple columns [pgadmin4] |