Re: PATCH: PGADMIN 4 - FTS templates node

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: PGADMIN 4 - FTS templates node
Date: 2016-02-25 14:07:00
Message-ID: CA+OCxozUe1K9V-JF3HQ+Aj8gdEep8xhxD-GxrdkUB_k11eu55w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Tue, Feb 23, 2016 at 1:44 PM, Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com
> wrote:

> Hi,
>
> PFA the revised patch for fts template node which includes dependency and
> dependent route handling code.
> Please do review it and if found proper please do commit it.
>

- When creating a new template, errors in the dialogue are not cleared -
e.g. the "Name must not be empty" doesn't clear, and save is not enabled,
even when a name is entered.

- "Fts Templates" should be "FTS Templates" on the treeview.

- The "Init" field should be labelled "Init Function"

- The "Lexize" field should be labelled "Lexize Function"

- Selecting a schema should be optional, with the default being the current
schema.

- 4 character indents are not consistently used in SQL templates

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-02-25 14:23:12 Re: PATCH: Collation node [pgAdmin4]
Previous Message Dave Page 2016-02-25 13:30:56 Re: pgAdmin4 PATCH: Domain Module