Re: configure doesn't detect SSL support in libpq

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: configure doesn't detect SSL support in libpq
Date: 2011-12-12 22:50:17
Message-ID: CA+OCxozLBJ1Nts0xLm=8fgbOQKCzeGAPVS4oD-LRW1N=u5ZYLw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Dec 13, 2011 at 2:48 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Hi,
>
> It seems our configure script doesn't detect SSL support in libpq. It
> detects the SSL library though.
>
> The following patch fixes it, but I'm not sure of it as I'm in no way an
> expert in those things;
>
> diff --git a/acinclude.m4 b/acinclude.m4
> index 4030966..0640a68 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -538,7 +538,7 @@ AC_DEFUN([SETUP_POSTGRESQL],
>                                        PG_SSL="no"
>                                fi
>                        else
> -                               AC_CHECK_LIB(pq, SSL_connect,
> [PG_SSL=yes], [PG_SSL=no])
> +                               AC_CHECK_LIB(pq, SSL_connect,
> [PG_SSL=yes], [PG_SSL=no], "-lssl")
>                        fi
>                fi
>                else
>
> Any comments would be appreciated :)

What exactly are you trying to fix? I spent quite a while on this last
cycle and though I'd ironed out all the wrinkles. Note that -lssl
isn't always enough - on some platforms you'll also need -lcrypt (or
-lcrypto, I forget which).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2011-12-12 23:03:22 Re: configure doesn't detect SSL support in libpq
Previous Message pgAdmin Trac 2011-12-12 22:35:12 Re: [pgAdmin III] #341: New connection option: sslcompression