| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Florian Sabonchi <sabonchi(at)posteo(dot)de> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: OAUTH2 implementation |
| Date: | 2021-03-30 15:48:32 |
| Message-ID: | CA+OCxoz72Hs6t35AXD7RWkPq6othvAFEg-_N7brUkEOyOTYfHA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Tue, Mar 30, 2021 at 3:36 PM Florian Sabonchi <sabonchi(at)posteo(dot)de> wrote:
> Hello in this patch I have implemented oauth2
>
> Cool!
Unfortunately the patch seems to be messed up. It adds a number of commits
that are already in the primary repo, and attempts to remove your OAuth
support, rather than adding it. Can you rebase it and make sure it only
includes the addition of your work please?
Some other comments (keep in mind it's hard to read the mangled patch, so I
may be missing something):
- There don't seem to be any documentation updates
- There don't seem to be any tests (which I grant may not be feasible to
add unless an OAuth service can be mocked)
- I can't see how you've dealt with password saving, which currently
requires a password from the user to be secure.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2021-03-31 06:38:08 | pgAdmin 4 commit: Fixed cannot unpack non-iterable response object erro |
| Previous Message | Florian Sabonchi | 2021-03-30 14:09:06 | OAUTH2 implementation |