| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#3175] Fix PEP-8 issues |
| Date: | 2018-03-07 11:48:01 |
| Message-ID: | CA+OCxoz5trs52yspwsu0uO0NB_UXy20VrSTLf-maMHo5fwskFA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, applied!
On Mon, Mar 5, 2018 at 4:23 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Thanks Joao for reviewing.
>
>
> On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira <
> jdealmeidapereira(at)pivotal(dot)io> wrote:
>
>> Hi Murtuza,
>>
>> Looks good, and all tests are green. I run the commands provided and
>> nothing pops up.
>>
>> Only missing 374 :D
>>
> :-)
>
>
>>
>> Thanks
>> Joao
>>
>> On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix PEP8 issues in Browser & Database modules,
>>> pycodestyle --config=.pycodestyle pgadmin/browser/__init__.py
>>> pycodestyle --config=.pycodestyle pgadmin/browser/tests/
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/__init__.py
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/tests/
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2018-03-07 11:52:07 | pgAdmin 4 commit: Disable function statistics on Greenplum. Fixes #3176 |
| Previous Message | Dave Page | 2018-03-07 11:47:05 | pgAdmin 4 commit: PEP8 fixes. Fixes #3175 |