Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

Hi

Some relatively minor details to fix please:

- There's no doc update.

- I think fa-trash-alt might be better for the Drop icon.

- I don't like the Drop Cascade icon. Maybe have Chethana create one based
on fa-trash-alt, shrunken a little with a downwards pointing arrow on the
bottom right.

Thanks!

On Tue, Oct 16, 2018 at 10:23 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the attached updated patch with the following changes.
> 1. Introduced header buttons for Drop and Drop Cascade
> 2. Fixed checkbox alignment issue
> 3. Refresh the grid on the error
>
> Currently I have removed multi delete table-space test case. I have tried
> to create sub directories but didn't work due to permission issue.
>
> Thanks,
> Khushboo
>
>
>
>
> On Tue, Oct 9, 2018 at 3:35 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Tue, Oct 9, 2018 at 8:03 AM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Mon, Oct 8, 2018 at 5:35 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Oct 8, 2018 at 12:50 PM Khushboo Vashi <
>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> On Mon, Oct 8, 2018 at 3:47 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>
>>>>>> Hi
>>>>>> On Fri, Oct 5, 2018 at 12:28 PM Khushboo Vashi <
>>>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Please find the attached updated patch with the fixes.
>>>>>>>
>>>>>>
>>>>>> Whenever I run the python tests, I get the following errors (even
>>>>>> after manually deleting all test tablespaces):
>>>>>>
>>>>>> I am not getting this error. My test cases are passing successfully.
>>>>> Do you have this issue on particular server or all the server?
>>>>>
>>>>
>>>> I'm just testing on PG10 at the moment (and have run the tests multiple
>>>> times).
>>>>
>>>>
>>>>> Which python version?
>>>>>
>>>>
>>>> 3.6.6.
>>>>
>>>>
>>> I have found the issue.
>>> For every new table-space, different path is required. We give the
>>> table-space path in the test_config.json file.
>>> Now to test the multiple delete, we need to give multiple paths.
>>> So, Should I configure the multiple paths in the test_config.json file
>>> or skip the multile delete tablespace test case?
>>>
>>
>> Can we create multiple sub-directories under the specified path?
>>
>>
>>>
>>>
>>> Thanks,
>>> Khushboo
>>>
>>>>
>>>>>
>>>>>> ======================================================================
>>>>>>
>>>>>> ERROR: runTest
>>>>>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete_multiple.TableSpaceDeleteTestCase)
>>>>>>
>>>>>> Delete Multiple Tablespaces
>>>>>>
>>>>>> ----------------------------------------------------------------------
>>>>>>
>>>>>> Traceback (most recent call last):
>>>>>>
>>>>>> File
>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>>>>>> line 59, in create_tablespace
>>>>>>
>>>>>> (test_tablespace_name, server['tablespace_path']))
>>>>>>
>>>>>> psycopg2.OperationalError: directory
>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in use as a
>>>>>> tablespace
>>>>>>
>>>>>>
>>>>>>
>>>>>> During handling of the above exception, another exception occurred:
>>>>>>
>>>>>>
>>>>>> Traceback (most recent call last):
>>>>>>
>>>>>> File
>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_delete_multiple.py",
>>>>>> line 44, in setUp
>>>>>>
>>>>>> self.server, self.tablespace_names[1])
>>>>>>
>>>>>> File
>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>>>>>> line 74, in create_tablespace
>>>>>>
>>>>>> raise Exception("Error while creating tablespace. %s" %
>>>>>> exception)
>>>>>>
>>>>>> Exception: Error while creating tablespace. directory
>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in use as a
>>>>>> tablespace
>>>>>>
>>>>>>
>>>>>>
>>>>>> ======================================================================
>>>>>>
>>>>>> ERROR: runTest
>>>>>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
>>>>>>
>>>>>> Check Tablespace Node
>>>>>>
>>>>>> ----------------------------------------------------------------------
>>>>>>
>>>>>> Traceback (most recent call last):
>>>>>>
>>>>>> File
>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>>>>>> line 59, in create_tablespace
>>>>>>
>>>>>> (test_tablespace_name, server['tablespace_path']))
>>>>>>
>>>>>> psycopg2.OperationalError: directory
>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in use as a
>>>>>> tablespace
>>>>>>
>>>>>>
>>>>>>
>>>>>> During handling of the above exception, another exception occurred:
>>>>>>
>>>>>>
>>>>>> Traceback (most recent call last):
>>>>>>
>>>>>> File
>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_get.py",
>>>>>> line 36, in setUp
>>>>>>
>>>>>> self.server, self.tablespace_name)
>>>>>>
>>>>>> File
>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>>>>>> line 74, in create_tablespace
>>>>>>
>>>>>> raise Exception("Error while creating tablespace. %s" %
>>>>>> exception)
>>>>>>
>>>>>> Exception: Error while creating tablespace. directory
>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in use as a
>>>>>> tablespace
>>>>>>
>>>>>>
>>>>>>
>>>>>> ======================================================================
>>>>>>
>>>>>> ERROR: runTest
>>>>>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
>>>>>>
>>>>>> Check Tablespace Node
>>>>>>
>>>>>> ----------------------------------------------------------------------
>>>>>>
>>>>>> Traceback (most recent call last):
>>>>>>
>>>>>> File
>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>>>>>> line 59, in create_tablespace
>>>>>>
>>>>>> (test_tablespace_name, server['tablespace_path']))
>>>>>>
>>>>>> psycopg2.OperationalError: directory
>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in use as a
>>>>>> tablespace
>>>>>>
>>>>>>
>>>>>>
>>>>>> During handling of the above exception, another exception occurred:
>>>>>>
>>>>>>
>>>>>> Traceback (most recent call last):
>>>>>>
>>>>>> File
>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_put.py",
>>>>>> line 36, in setUp
>>>>>>
>>>>>> self.server, self.tablespace_name)
>>>>>>
>>>>>> File
>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>>>>>> line 74, in create_tablespace
>>>>>>
>>>>>> raise Exception("Error while creating tablespace. %s" %
>>>>>> exception)
>>>>>> Exception: Error while creating tablespace. directory
>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in use as a
>>>>>> tablespace
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company