Re: wxWidgets 2.9.2 compatibility

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: wxWidgets 2.9.2 compatibility
Date: 2011-07-13 13:39:46
Message-ID: CA+OCxoydbdYN19jjeFHqwMMtNFigJi00-xdkt-asn22zPbsXBw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Jul 13, 2011 at 10:27 AM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
> On 12 July 2011 17:45, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> So here's the patch I needed to get pgAdmin to build against wxWidgets
>> 2.9.2 on Mac. The only obvious problem I see with it when running is
>> that the toolbars are displaying text over the graphical buttons which
>> needs further investigation.
>
> I don't have time to help you with that at the moment I'm afraid.

I wasn't asking you to :-)

>> I'm not really sure why the compiler is unable to resolve this:
>>
>> ./slony/dlgRepCluster.cpp:815: error: request for member
>> ‘GetClientData’ is ambiguous
>> /usr/local/include/wx-2.9/wx/ctrlsub.h:297: error: candidates are:
>> void* wxItemContainer::GetClientData(unsigned int) const
>> /usr/local/include/wx-2.9/wx/event.h:3234: error:
>> void* wxEvtHandler::GetClientData() const
>
> I told you about this back in February I think, where I demonstrated
> that GCC gives crappy error messages when it encounters the dastardly
> diamond:
>
> http://postgresql.1045698.n5.nabble.com/Building-with-wx2-9-on-Mac-td3397898.html#a3397998

Ahh, yes - that one.

Anyhoo, I'm looking to commit the patch so we can move forward. Objections?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2011-07-13 14:01:27 Re: wxWidgets 2.9.2 compatibility
Previous Message Peter Geoghegan 2011-07-13 09:27:54 Re: wxWidgets 2.9.2 compatibility