From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Rikard Pavelic <rikard(dot)pavelic(at)zg(dot)htnet(dot)hr>, Craig Ringer <ringerc(at)ringerc(dot)id(dot)au>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Subject: | Re: BUG #7485: 9.2 beta3 libxml2 can't be loaded on Windows |
Date: | 2012-08-16 14:28:43 |
Message-ID: | CA+OCxoySJ03p0b9yfxM0rNpuBAxtLKu2qOxng+WoXu4V0sKvDg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Thu, Aug 16, 2012 at 3:26 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Dave Page <dpage(at)pgadmin(dot)org> writes:
>> So Sachin and I have looked at this but not found a problem with the
>> installers. He then found that one of our colleagues has already
>> reported this as an issue with PostgreSQL and submitted a possible
>> patch. So, we need a committer to look at fixing this:
>
>> http://archives.postgresql.org/pgsql-hackers/2012-06/msg00874.php
>
> Seems pretty brute-force. Why not just
>
> #if LIBXML_VERSION > 20703
> #define HAVE_XMLSTRUCTUREDERRORCONTEXT
> #endif
>
> in some suitable place (probably xml.c itself, since I don't think we
> want to #include xmlversion.h in global headers)?
>
> Or actually, maybe we could just unconditionally define
> HAVE_XMLSTRUCTUREDERRORCONTEXT in pg_config.h.win32. Is anybody
> likely to still be building PG with ancient libxml on Windows?
That works for me. Using older libxml's would be a bad idea anyway -
and there are precompiled binaries available, so it's not hard to get.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2012-08-16 14:29:59 | Re: BUG #7485: 9.2 beta3 libxml2 can't be loaded on Windows |
Previous Message | Tom Lane | 2012-08-16 14:26:27 | Re: BUG #7485: 9.2 beta3 libxml2 can't be loaded on Windows |