Re: Changed default ordering in tables

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Erwin Brandstetter <brandstetter(at)falter(dot)at>, "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: Changed default ordering in tables
Date: 2011-08-06 13:02:57
Message-ID: CA+OCxoyHxrcj2E5U9=RNpqESAhdpJyMDtOdVEaPRne7b0Th24Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks. I thought i checked for the var init. Guess i missed a code path.

On Saturday, August 6, 2011, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
wrote:
> On Fri, 2011-07-29 at 10:33 +0100, Dave Page wrote:
>> On Fri, Jul 29, 2011 at 9:14 AM, Erwin Brandstetter
>> <brandstetter(at)falter(dot)at> wrote:
>> > So, that's two distinct issue:
>> > - "Last 100 rows" broken for multi-column pkeys.
>> > - Default sort order DESC for edit grid, where it should be ASC.
>>
>> That one I can reproduce, and fix. Patch attached.
>>
>> Ashesh, can you review and test please? We're getting close to release
>> so I want to be extra careful.
>>
>
> I checked your patch. Seems good to me. So I applied it. I also applied
> another patch to fix Erwin's bug (missing initialization of the
> pkAscending variable).
>
>
> --
> Guillaume
> http://blog.guillaume.lelarge.info
> http://www.dalibo.com
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2011-08-06 13:33:10 Re: Copy/Paste table(s) functions - git context patch
Previous Message Guillaume Lelarge 2011-08-06 12:49:42 Re: Changed default ordering in tables