Re: PgAgent 3.3.0 batch scripts on windows always get status failed

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Bastiaan Olij <bastiaan(at)basenlily(dot)me>
Cc: pgAdmin Support <pgadmin-support(at)postgresql(dot)org>
Subject: Re: PgAgent 3.3.0 batch scripts on windows always get status failed
Date: 2013-02-06 19:28:41
Message-ID: CA+OCxoxb5kRXbDWz9zV09zX=KS6LCrraY30NAUdOc4WMv+WxyQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

Hi

On Mon, Feb 4, 2013 at 11:23 PM, Bastiaan Olij <bastiaan(at)basenlily(dot)me> wrote:
> Hi Dave,
>
> I don't think that will work, yes it will get the proper rc value but it
> still leaves succeeded set to false. It needs inclusion of a check to
> see if rc==0 and if so set succeeded to true provided that a successful
> script indeed returns an error level of 0 (which I think it should).

Yeah, of course it is somewhat more complex than that. I've attached a
patch thats seems to work for me.

> And yes, if you could send me a new binary then we are able to test this
> swiftly. We do currently use the enterprisedb distributable so I'm
> taking the assumption I'll be able to just drop the new .exe in place of
> the old for this.

Thanks - I'll send you a link to an updated executable off-list.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
batch_errors.diff application/octet-stream 2.4 KB

In response to

Browse pgadmin-support by date

  From Date Subject
Next Message Tim Romano 2013-02-06 19:58:26 cannot get Debugger to install on 9.2 on Win7 x-64
Previous Message Dave Page 2013-02-06 17:19:06 Re: ESC closes window without warning