Re: New key shortcuts for query window

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Thom Brown <thom(at)linux(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: New key shortcuts for query window
Date: 2011-07-12 10:46:11
Message-ID: CA+OCxoxaDg=N_UC4tzSGCXxqcjH+i9xB2B0jrUDGwVbbB2TahQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Jul 12, 2011 at 11:28 AM, Thom Brown <thom(at)linux(dot)com> wrote:
> On 12 July 2011 11:11, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> On Tue, Jul 12, 2011 at 11:03 AM, Thom Brown <thom(at)linux(dot)com> wrote:
>>> On 12 July 2011 10:59, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>> On Sun, Jul 10, 2011 at 1:45 PM, Thom Brown <thom(at)linux(dot)com> wrote:
>>>>> Hi all,
>>>>>
>>>>> I think the SQL query window should have a File > Close menu item,
>>>>> which maps to Ctrl+W (or Apple+W in the case of a Mac).  This is easy
>>>>> to add.
>>>>
>>>> We already have File -> Exit, which uses Ctrl+W. On the Mac, that
>>>> currently gets mapped to pgAdmin3 -> Quit pgAdmin3, which is Cmd+Q.
>>>
>>> But Cmd+Q tends to mean quit application rather than exit window, at
>>> least it does in all the other apps I use.  And I don't have a
>>> File>Exit on my Query window in PgAdmin on the Mac.
>>
>> That's because wxWidgets maps the Exit option to Quit on the Mac. And
>> yes, this doesn't need cleanup...
>
> This is still inconsistent with virtually ever other application on
> OSX, so I think this is something wrong with wxWidgets then.

No, it maps Exit to Quit - that's consistent. It's us that are using
Exit on lower level windows which is not really right (interestingly,
it is on the query tool, *if* it's started standalone).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin Trac 2011-07-12 11:02:56 [pgAdmin III] #327: Table SQL pane doesn't show column variables
Previous Message Thom Brown 2011-07-12 10:28:39 Re: New key shortcuts for query window