Re: More information about the selected objects

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Vinicius Santos <vinicius(dot)santos(dot)lista(at)gmail(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Subject: Re: More information about the selected objects
Date: 2012-07-18 12:15:11
Message-ID: CA+OCxoxXj5yNaEVQJ4mPEZyV5fjE_+PCeG5gMVanG-sPGJdpfw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Jul 18, 2012 at 1:50 AM, Vinicius Santos
<vinicius(dot)santos(dot)lista(at)gmail(dot)com> wrote:
> I fixed the problems.

That's better.

> I removed the implementation on EnterpriseDB items, because I don't have how
> to test it. Can you help to test it?

I can test the PPAS stuff, but not the Greenplum objects. But... they
shouldn't be an issue - if an object is derived from pgSchema, you can
(and should use GetSchema(). If it's derived from a pgTable, you
probably want the table name too. If it's derived from pgObject,
pgServer, pgDatabase, then there's no schema available.

> I tested on Windows 7 and Ubuntu.

I noted a few problems.

- First, the patch exhibits exactly the problem I was talking about.
See the attached screenshot, which is just a mess. All of the names
(server, object, username etc) are real. None are made up. And yes,
despite what Microsoft seem to be wanting people to do from Windows 8
onwards, I usually don't have full screen windows, but tend to work
with smaller ones side-by-side.

- Not only do I see truncated names, but more importantly the "Done."
is not visible. That is *essential*, for obvious reasons.

- We try to avoid referring to servers by their hostname/IP address in
the UI (anywhere we do, is an oversight). You should be showing the
name. In my case, for remote servers that tends to be the hostname
anyway. For local servers though, it's usually a string like
"PostgreSQL 9.1" or "Postgres Plus Advanced Server 9.1". The reasoning
is that the name is a memorable string that the user can easily
recognise, whilst the hostname or IP address usually isn't (for
example, Amazon EC2 hostnames - which of course, are also very long).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
Screen Shot 2012-07-18 at 13.02.24.png image/png 202.3 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Vinicius Santos 2012-07-18 12:50:27 Re: More information about the selected objects
Previous Message Dave Page 2012-07-18 11:36:13 Re: SSH Tunneling implementation