Re: [PATCH 2/2] Improve references to the mailing list in docs

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Chris Mayo <aklhfex(at)gmail(dot)com>
Cc: "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH 2/2] Improve references to the mailing list in docs
Date: 2016-10-10 08:33:44
Message-ID: CA+OCxoxCdS2UQaO_Kn5v1Ww46L_oEs_jVABsASes0uLfw=ypNA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

BTW, please send any future patches as attachments rather than inline, as I
had to apply this manually as it got munged in the email body.

Thanks!

On Sunday, October 9, 2016, Chris Mayo <aklhfex(at)gmail(dot)com> wrote:

> Just let Sphinx discover the email address; displays better in
> browser and pgAdmin4 runtime.
>
> Signed-off-by: Chris Mayo <aklhfex(at)gmail(dot)com <javascript:;>>
> ---
> docs/en_US/contributions.rst | 2 +-
> docs/en_US/submitting_patches.rst | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/en_US/contributions.rst b/docs/en_US/contributions.rst
> index a395e12..7cd3026 100644
> --- a/docs/en_US/contributions.rst
> +++ b/docs/en_US/contributions.rst
> @@ -4,7 +4,7 @@
> pgAdmin Project Contributions
> *****************************
>
> -pgAdmin is an open-source project that invites you to get involved in the
> development process. For more information about contributing to the
> pgAdmin project, contact the developers on the pgAdmin mailing list <mailto:
> pgadmin-hackers(at)postgresql(dot)org <javascript:;>> to discuss any ideas you
> might have for enhancements or bug fixes.
> +pgAdmin is an open-source project that invites you to get involved in the
> development process. For more information about contributing to the
> pgAdmin project, contact the developers on the pgAdmin mailing list
> pgadmin-hackers(at)postgresql(dot)org <javascript:;> to discuss any ideas you
> might have for enhancements or bug fixes.
>
> In the sections listed below, you'll find detailed information about the
> development process used to develop, improve, and maintain the pgAdmin
> client.
>
> diff --git a/docs/en_US/submitting_patches.rst b/docs/en_US/submitting_
> patches.rst
> index 9f8ab42..a3ced06 100644
> --- a/docs/en_US/submitting_patches.rst
> +++ b/docs/en_US/submitting_patches.rst
> @@ -5,7 +5,7 @@ Submitting Patches
> ******************
>
> Before developing a patch for pgAdmin you should always contact the
> developers
> -on the `mailing list <mailto:pgadmin-hackers(at)postgresql(dot)org
> <javascript:;>>` to discuss your
> +on the mailing list pgadmin-hackers(at)postgresql(dot)org <javascript:;> to
> discuss your
> plans. This ensures that others know if you're fixing a bug and can then
> avoid
> duplicating your work, and in the case of large patches, gives the
> community
> the chance to discuss and refine your ideas before investing too much time
> @@ -31,6 +31,6 @@ to create a patch between your development branch and
> the public master branch.
> Once you have your patch, check it thoroughly to ensure it meets the
> pgAdmin
> :doc:`coding_standards`, and review it against the :doc:`code_review` to
> minimise
> the chances of it being rejected. Once you're happy with your work, mail
> it to the
> -`mailing list <mailto:pgadmin-hackers(at)postgresql(dot)org <javascript:;>>`.
> Please ensure you
> +mailing list pgadmin-hackers(at)postgresql(dot)org <javascript:;>. Please
> ensure you
> include a full description of what the patch does, as well as the
> rationale for
> any important design decisions.
> \ No newline at end of file
> --
> 2.7.3
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org
> <javascript:;>)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-10-10 08:43:03 pgAdmin 4 commit: Fix View privilege management. Fixes #1531
Previous Message Dave Page 2016-10-10 08:33:34 Re: [PATCH 1/2] Fix link to code_review in submitting_patches.rst