From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes |
Date: | 2016-06-15 10:59:32 |
Message-ID: | CA+OCxowrbL=wE51LJHLy+9FHwLwQn3myTcLjdu7RH7M0AUMCXg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied.
On Wed, Jun 15, 2016 at 8:21 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi Ashesh,
>
> I have revert back the changes made in backgrid-sizeable.css and override
> the table.backgrid css of resizable in overrides.css.
> Please find the patch and review.
>
> On Wed, Jun 15, 2016 at 10:42 AM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> OK, I will fix it.
>>
>> On Wed, Jun 15, 2016 at 10:41 AM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> On Tue, Jun 14, 2016 at 8:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Fix query tool horizontal scrolling of results. Fixes #1362
>>>>
>>>> The backgrid-sizeable's css property 'overflow: hidden' was overriding
>>>> backgrid table css property and It was reproducible only in runtime.
>>>> Removed 'overflow: hidden' property from backgrid-sizeabled-columns.css
>>>>
>>>> Branch
>>>> ------
>>>> master
>>>>
>>>> Details
>>>> -------
>>>>
>>>> http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e881695050b8ba4cf99b365ff2c0f4e02d03ced6
>>>> Author: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
>>>>
>>>> Modified Files
>>>> --------------
>>>> web/pgadmin/static/css/backgrid/backgrid-sizeable-columns.css | 1 -
>>>>
>>> This is not correct place to handle the issue.
>>>
>>> We should not change third party CSS.
>>> We should handle this issue in override.css.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com/>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi>
>>>
>>>
>>>> web/pgadmin/static/js/backform.pgadmin.js | 5 +----
>>>> 2 files changed, 1 insertion(+), 5 deletions(-)
>>>>
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>
>>>
>>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2016-06-15 11:02:27 | Re: [pgadmin-hackers] PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4) |
Previous Message | Dave Page | 2016-06-15 10:59:23 | pgAdmin 4 commit: A more appropriate fix for RM1362 - horizontal scroll |