Re: [pgAdmin4][Patch]: TypeError: Cannot read property 'generate_url' of undefined

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: TypeError: Cannot read property 'generate_url' of undefined
Date: 2016-06-08 11:47:12
Message-ID: CA+OCxowYAE1Rsd+dWzSRy6MGndKGdi+8rP1_7b5fYLap8RburQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Tue, Jun 7, 2016 at 12:02 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Issue: When any of the docked tab(statistics, dependents & dependencies) are
> clicked without selecting any tree node. it gives error in browser console
> panel.
> Because the node passed is undefined. and check is missing. This is now
> fixed by adding check for node passed.
>
> So, please review the attached patch for the fix.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-06-08 11:48:55 pgAdmin 4 commit: Fix validation issue causing statistics tab to break
Previous Message Dave Page 2016-06-08 11:46:54 pgAdmin 4 commit: When any of the docked tab(statistics, dependents & d