Re: Compilation on Debian SID

On Sat, Nov 26, 2011 at 12:38 AM, Olly Betts <olly(at)survex(dot)com> wrote:
> philippe rimbault <philippe(at)rimbault(dot)org> writes:
>> There is also this bug (Mon, 24 Oct 2011) from debian FTBFS about pgadmin3:
>> http://www.mail-archive.com/debian-bugs-dist(at)lists(dot)debian(dot)org/msg953221.html
>> And this thread about building pgadmin with wx2.9 (i'm using wx2.8 but there
>> is the same error):
>> http://archives.postgresql.org/pgadmin-hackers/2011-01/msg00125.php
>
> The reason this code has stopped building is that wxwidgets2.8 in Debian
> unstable was recently patched to stop defining the ATTRIBUTE_PRINTF* macros
> (which are too generically named and cause clashes with other software)
> and to instead define WX_ATTRIBUTE_PRINTF* (as wx2.9 already does).  This
> patch can be seen here:
>
> http://patch-tracker.debian.org/patch/series/view/wxwidgets2.8/2.8.12.1-3/fix-
> macro-namespace-pollution.patch
>
> The bug motivating this change is here:
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521924

Hmm, thanks for the info. I really thought the Debian guys had stopped
unilaterally breaking wxWidgets like that (downstream patching used to
cause other problems with Debian in years gone by). Reminds me of why
I prefer Redhat.

> My take on this is that the ATTRIBUTE_PRINTF* macros weren't intended to be
> used outside of the wx headers - there aren't publicly documented anywhere,
> and wx upstream has renamed them in 2.9 without mentioning the fact in
> docs/changes.txt (which is intended to document all wx API changes).
>
> So I would say it's a bug in pgadmin that it makes use of these macros -
> it should define them itself if it needs them (and to avoid clashes with
> everyone else who carelessly defines them without thinking through the
> implications, it ought to define something like PG_ATTRIBUTE_PRINTF*
> instead of ATTRIBUTE_PRINTF*).

There are a lot of things that aren't documented in wxWidgets. If we
removed all of them from pgAdmin... well, we just couldn't.
Unfortunately we can't just copy them because the licences aren't
compatible.

Anyway, thanks again for the info - I guess we'll just check to see if
WX_ATTRIBUTE_PRINTF* is defined, and if so use that instead of
ATTRIBUTE_PRINTF*.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company