Re: [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries
Date: 2017-02-06 10:01:43
Message-ID: CA+OCxowNqi4vk1bwbxVBq=PoW+B1-mNJ-JOF_w5kv56_AYZirg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Feb 6, 2017 at 5:40 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue with Graphical Explain plan functionality which
> was breaking for INSERT/UPDATE/DELETE explain plans.
> RM#2133
>
> Issue: It was due to typo in imageMapper object.
>
> Please review.

It's a definite improvement, but still isn't quite right - see the
attached screenshot for example; the node name should be pem.agent
shouldn't it (or 'Delete' or 'Delete from pem.agent')?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
image/png 27.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-02-06 10:20:30 [pgAdmin4][PATCH] To handle "char" type in column node
Previous Message Dave Page 2017-02-06 09:49:28 Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type