Re: Same sub-menu name for disconnectDatabaseFactory and disconnectServerFactory.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Subject: Re: Same sub-menu name for disconnectDatabaseFactory and disconnectServerFactory.
Date: 2012-08-28 14:46:23
Message-ID: CA+OCxowEG-khkSDz6SLMBQMSVFMiUB-WTqj76kg4o+Zqa3J_ig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied (though, I lower-cased the second words for
consistency with most of the rest of the options). Guillaume, please
note - this affects translations.

We should review all these options in the future, and ensure we use
standardised capitalisation.

On Tue, Aug 28, 2012 at 1:51 PM, Sachin Srivastava
<sachin(dot)srivastava(at)enterprisedb(dot)com> wrote:
> Yes. See attached..
>
>
> On Tue, Aug 28, 2012 at 6:09 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> Do both options ever show up on the same menu together?
>>
>> On Tue, Aug 28, 2012 at 1:22 PM, Sachin Srivastava
>> <sachin(dot)srivastava(at)enterprisedb(dot)com> wrote:
>> > Hi all,
>> >
>> > Sub-Menu name "Disconnect" is same for disconnectDatabaseFactory and
>> > disconnectServerFactory.
>> >
>> > Attached patch fixes the issue. I have kept the shortcut key same
>> > because
>> > both Menu options can never be enable at the same time.
>> >
>> > --
>> > Regards,
>> > Sachin Srivastava
>> > EnterpriseDB, India
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
>
> --
> Regards,
> Sachin Srivastava
> EnterpriseDB, India

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2012-08-28 15:51:05 SetSize function never called in case of modal dialog
Previous Message Dave Page 2012-08-28 14:45:00 pgAdmin III commit: Clarify disconnect menu option labels.