Re: Subnode grid row close issue [pgAdmin4]

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Subnode grid row close issue [pgAdmin4]
Date: 2016-03-22 17:05:03
Message-ID: CA+OCxow164hMXZvG6T2KUYPvJTOnMLY8J-iWTQruCeFi8_57kQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - applied.

On Thu, Mar 17, 2016 at 3:04 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Here is updated patch.
>
> In initial patch I fixed this issue in only Subnode control while Type
> node uses unique collection control (which is special case of subnode
> control). Now I have fixed in both control.
>
>
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB <http://www.enterprisedb.com>
>
> On Thu, Mar 17, 2016 at 6:41 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, Mar 17, 2016 at 11:14 AM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch for Subnode grid row close issue.
>>>
>>> Issue fixed:
>>>
>>> 1] Close any existing row while adding new row.
>>> 2] Close any existing row if we edit new row.
>>>
>>
>> This doesn't appear to make any difference to me. I've confirmed the
>> patch is applied, restarted the app, emptied my cache and reloaded, and
>> tested with composite types on the Create Type dialogue. I still see
>> multiple row forms when I hit the ADD button if one is already open.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-03-22 17:10:16 Re: pgAdmin4 PATCH: Domain Module
Previous Message Dave Page 2016-03-22 17:04:49 pgAdmin 4 commit: Fix issues with multiple subnode forms being open at