Re: Segmentation fault on proc exit after dshash_find_or_insert

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Rahila Syed <rahilasyed90(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Segmentation fault on proc exit after dshash_find_or_insert
Date: 2025-12-18 08:20:00
Message-ID: CA+HiwqHzTpLH9q3XHSiXndCgVYi8CvaeOcMgu7ZoYS2XOYqtiA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 18, 2025 at 2:01 PM Rahila Syed <rahilasyed90(at)gmail(dot)com> wrote:
>
> Hi Amit,
>
>>
>> /*
>> * Release any LWLocks we might be holding before callbacks run. This
>> * prevents accessing locks in detached DSM segments and allows callbacks
>> * to acquire new locks.
>> */
>>
>
> This looks good to me.

Thanks. Updated the commit message too to be more accurate in the
attached updated patch.

I'll wait a bit more (until next year :)) before committing this so
maybe others can comment on it.

--
Thanks, Amit Langote

Attachment Content-Type Size
v4-0001-Fix-segfault-from-releasing-locks-in-detached-DSM.patch application/octet-stream 4.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-12-18 08:35:14 Re: pg_dump crash due to incomplete ordering of DO_SUBSCRIPTION_REL objects
Previous Message Chao Li 2025-12-18 07:52:17 Re: Add sanity check for duplicate enum values in GUC definitions