From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: a comment in joinrel.c: compute_partition_bounds() |
Date: | 2021-10-07 03:04:58 |
Message-ID: | CA+HiwqHf4=aH1K+XnBmggcVN=AtVR_Cc0vntez5zTG_FSZ_e2w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Fujita-san,
On Wed, Oct 6, 2021 at 5:41 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Fri, Sep 24, 2021 at 4:20 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > On Fri, Sep 24, 2021 at 3:34 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > I think there's a word missing in the following comment:
> > >
> > > /*
> > > * See if the partition bounds for inputs are exactly the same, in
> > > * which case we don't need to work hard: the join rel have the same
> > > * partition bounds as inputs, and the partitions with the same
> > > * cardinal positions form the pairs.
> > >
> > > ": the join rel have the same..." seems to be missing a "will".
> > >
> > > Attached a patch to fix.
> >
> > Good catch! Will fix.
>
> Rereading the comment, I think it would be better to add “will” to the
> second part “the partitions with the same cardinal positions form the
> pairs” as well. Updated patch attached.
No objection from my side.
Thank you.
--
Amit Langote
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | kuroda.hayato@fujitsu.com | 2021-10-07 03:07:33 | Question about client_connection_check_interval |
Previous Message | kuroda.hayato@fujitsu.com | 2021-10-07 02:46:36 | RE: Allow escape in application_name |