Re: Segmentation fault on proc exit after dshash_find_or_insert

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Rahila Syed <rahilasyed90(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Segmentation fault on proc exit after dshash_find_or_insert
Date: 2026-01-16 05:52:49
Message-ID: CA+HiwqHSSqUDLrPcBtydSdMuX+KPt7ROhDDLaN_XyeqG8vi99w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Álvaro,

On Wed, Jan 14, 2026 at 10:56 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Wed, Jan 14, 2026 at 6:36 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote
> > I would add an Assert(num_held_lwlocks == 0) at the
> > end of LWLockReleaseAll(), to make it clear that it's idempotent (which
> > is important for the case where ProcKill will call it again shortly
> > after).
>
> Makes sense. Will do.

Done and pushed. I struggled to write a comment to describe the Assert though.

--
Thanks, Amit Langote

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2026-01-16 05:54:44 Re: log_min_messages per backend type
Previous Message John Naylor 2026-01-16 05:51:59 Re: refactor architecture-specific popcount code