Re: BUG #19484: Segmentation fault triggered by FDW

On Thu, Jun 18, 2026 at 19:55 Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:

> Sorry, I accidentally sent this before I finished writing.
>
> On Thu, Jun 18, 2026 at 7:50 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
> wrote:
> >
> > Amit-san,
> >
> > On Thu, Jun 18, 2026 at 6:16 PM Amit Langote <amitlangote09(at)gmail(dot)com>
> wrote:
> > > A small clarification on this one: the patch makes no changes to
> > > postgres_fdw code, only adds a regression test. The bug, which I
> > > introduced, is in how nodeModifyTable.c supplies fdw_private from the
> > > pruned/validated fdwPrivLists in ModifyTableState rather than the
> > > original list in ModifyTable, so the postgres_fdw side itself is
> > > unchanged. The substantive change is the executor re-indexing.
> >
> > Thanks for the clarification!
> >
> > > Still holding off on committing per our exchange, but no rush given
> > > you may want to prioritize the v19 open items. Happy to go ahead
> > > whenever, or wait for your comments.
>
> Actually, I've just started reviewing the patch. I'll let you know
> the results (if any) by tomorrow. Thanks for the consideration as
> well.

Ah, thanks for the heads up.

- Amit

>