| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Ordered Partitioned Table Scans |
| Date: | 2019-04-02 12:26:26 |
| Message-ID: | CA+HiwqHPgV6S1gHAsGtoC1vE0KkL6DMuuC6ZFLYatiFPepz1AA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi David,
On Tue, Apr 2, 2019 at 8:49 PM David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> I ended up rewording the entire thing and working on the header
> comment for the function too. I think previously it wasn't that well
> defined what "ordered" meant. I added a mention that we expect that
> NULLs, if possible must come in the last partition.
Thanks for the updated patch.
New descriptions look good, although was amused by this:
diff --git a/src/backend/partitioning/partbounds.c
b/src/backend/partitioning/partbounds.c
index bdd0d23854..9dd378d7a0 100644
--- a/src/backend/partitioning/partbounds.c
+++ b/src/backend/partitioning/partbounds.c
@@ -25,6 +25,7 @@
#include "miscadmin.h"
#include "nodes/makefuncs.h"
#include "nodes/nodeFuncs.h"
+#include "nodes/pathnodes.h"
...
+partitions_are_ordered(struct RelOptInfo *partrel)
Maybe, "struct" is unnecessary?
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-04-02 12:43:56 | Re: [HACKERS] generated columns |
| Previous Message | Peter Eisentraut | 2019-04-02 12:26:08 | Re: Unified logging system for command-line programs |