| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, rmt(at)lists(dot)postgresql(dot)org |
| Subject: | Re: RI fastpath misses checking EXECUTE on functions |
| Date: | 2026-09-29 12:49:21 |
| Message-ID: | CA+HiwqH=TakHqLfoYZQWQBvijRoZV3O-FF3tWALOMGXtk2dpSg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Kirill,
On Tue, Sep 29, 2026 at 9:37 PM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> On Sat, 26 Sept 2026 at 07:16, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> >
> > On Fri, Sep 25, 2026 at 8:45 PM Matheus Alcantara
> > <matheusssilv97(at)gmail(dot)com> wrote:
> > > On 25/09/26 05:16, Amit Langote wrote:
> > > >> ri_CheckFunctionPermissions(riinfo, fpmeta) passes both when fpmeta
> > > >> == riinfo->fpmeta. I'm wondering if we could just pass riinfo?
> > > >
> > > > That's just for consistency with build_index_scankeys(); it isn't
> > > > needed, so I don't feel strongly either way.
> > > >
> > >
> > > Ok, make sense.
> > >
> > > >> IIUC this patch only fix the case for FastPath without batching right?
> > > >> Since batching is still on master, I'm wondering if we could also fix
> > > >> it. See attached patch (v2-0001 is your v1-0001).
> > > >
> > > > I've left the batch code alone because I intend to revert it from
> > > > master too sometime next week. Thanks for the patch, though.
As I wrote here, I intend to revert this piece of code in master. I
haven't gotten around to it yet due to some personal circumstances at
the moment, but I aim to get it done by EOW.
Thanks for your attention and the patch nonetheless.
--
Thanks, Amit Langote
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maxime Schoemans | 2026-09-29 12:53:33 | Re: Set calcSumX2 = true in numeric_(poly_)deserialize |
| Previous Message | Kirill Reshke | 2026-09-29 12:37:39 | Re: RI fastpath misses checking EXECUTE on functions |