Re: Delay the variable initialization in get_rel_sync_entry

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>
Subject: Re: Delay the variable initialization in get_rel_sync_entry
Date: 2022-01-06 05:16:25
Message-ID: CA+HiwqH=R8163DAy=75vL4KPD5dEHHfv7BqUKQcaXYNjhJXEPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 5, 2022 at 10:31 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Dec 24, 2021 at 01:27:26PM +0000, houzj(dot)fnst(at)fujitsu(dot)com wrote:
> > Here is the perf result of pgoutput_change after applying the patch.
> > I didn't notice something else that stand out.
> >
> > |--2.99%--pgoutput_change
> > |--1.80%--get_rel_sync_entry
> > |--1.56%--hash_search
> >
> > Also attach complete profiles.
>
> Thanks. I have also done my own set of measurements, and the
> difference is noticeable in the profiles I looked at. So, applied
> down to 13.

Thanks. I agree the variables were being defined in the wrong place
before this patch.

--
Amit Langote
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-01-06 05:19:08 Re: GUC flags
Previous Message Michael Paquier 2022-01-06 05:04:07 Re: Refactoring of compression options in pg_basebackup