| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, Maciek Sakrejda <maciek(at)pganalyze(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Question about duplicate JSONTYPE_JSON check |
| Date: | 2025-03-13 03:51:43 |
| Message-ID: | CA+HiwqH=9BRVM=Gn-EQkcgjKijWicVt-jxQEjdqr6Gix2-vRKA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 12, 2025 at 21:40 Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
wrote:
> On 2025-Mar-12, Amit Langote wrote:
>
> > Patch look good for committing?
>
> Ah sorry, I should have said so -- yes, it looks good to me.
Thanks (Maciek, Tender too) for the review.
I feel a
> slight dislike for using URL-escaped characters in the mailing list link
> you added, because it means I cannot directly copy/paste the message-id
> string into my email client program. Not a huge issue for sure, and it
> seems a majority of links in the source tree are already like that
> anyway, but this seems an inclusive, safe, welcoming nitpicking space :-)
Ah, no problem, fixed it. I prefer to see URLs in that way too, but somehow
didn’t notice what I had done.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-03-13 04:00:15 | pgsql: Avoid invalidating all RelationSyncCache entries on publication |
| Previous Message | Dilip Kumar | 2025-03-13 03:48:34 | Re: Add an option to skip loading missing publication to avoid logical replication failure |