Re: Some memory not freed at the exit of RelationBuildPartitionDesc()

On Thu, Aug 8, 2019 at 5:33 PM amul sul <sulamul(at)gmail(dot)com> wrote:
> On Thu, Aug 8, 2019 at 1:27 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:

>> Thanks for the patch. This was discussed recently in the "hyrax vs.
>> RelationBuildPartitionDesc()" thread [1] and I think Alvaro proposed
>> an approach that's similar to yours. Not sure why it wasn't pursued
>> though. Maybe the reason is buried somewhere in that discussion.
>
> Oh, quite similar, thanks Amit for pointing that out.
>
> Look like "hyrax vs.RelationBuildPartitionDesc()" is in discussion for the master
> branch only, not sure though, but we need the similar fix for the back branches as well.

Well, this is not a bug as such, so it's very unlikely that a fix like
this will be back-patched. Also, if this becomes an issue only for
more than over 1000 partitions, then it's not very relevant for PG 10
and PG 11, because we don't recommend using so many partitions with
them. Maybe we can consider fixing PG 12 though.

Thanks,
Amit