| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <dgrowleyml(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> |
| Subject: | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |
| Date: | 2022-07-20 14:09:07 |
| Message-ID: | CA+HiwqGu5BcJw09c+2FQORZFqXKjdQXyKz+Ppb3wcUa5sU=1Hw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 20, 2022 at 12:37 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2022-07-19 20:40:11 +0900, Amit Langote wrote:
> > About that, I was wondering if the blocks in llvm_compile_expr() need
> > to be hand-coded to match what's added in ExecInterpExpr() or if I've
> > missed some tool that can be used instead?
>
> The easiest way is to just call an external function for the implementation of
> the step. But yes, otherwise you need to handcraft it.
Ok, thanks.
So I started updating llvm_compile_expr() for handling the new
ExprEvalSteps that the patch adds to ExecExprInterp(), but quickly
realized that code could have been consolidated into less code, or
IOW, into fewer new ExprEvalSteps. So, I refactored things that way
and am now retrying adding the code to llvm_compile_expr() based on
new, better consolidated, code.
Here's the updated version, without the llvm pieces, in case you'd
like to look at it even in this state. I'll post a version with llvm
pieces filled in tomorrow. (I have merged the different patches into
one for convenience.)
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Some-improvements-to-JsonExpr-evaluation.patch | application/octet-stream | 45.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-07-20 14:12:43 | Re: pgsql: Default to hidden visibility for extension libraries where possi |
| Previous Message | Tom Lane | 2022-07-20 14:09:01 | Re: pgsql: Default to hidden visibility for extension libraries where possi |