| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] path toward faster partition pruning |
| Date: | 2018-04-06 15:41:06 |
| Message-ID: | CA+HiwqGtW0+uZ831PrgZGEauHE3wwOV_kOn6+WAzGswDHU1n-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 6, 2018 at 11:38 PM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Yeah, there is one sentence there I didn't quite understand and would
> like to add it to the rewritten version of the comment before I remove
> the whole ifdeffed-out comment.
>
> * PARTCLAUSE_MATCH_STEPS: *clause_steps set to list of "partition pruning
> * step(s)" generated for the clause due to it being a BoolExpr or a
> * ScalarArrayOpExpr that's turned into one
>
> Exactly what does "ScalarArrayOpExpr that's turned into one" means?
> Does it mean we turn SAOP into BoolExpr?
Yes, we turn a ScalarArrayOpExpr into a BoolExpr and generate prune
step for the latter. Maybe we'll have a base pruning step that can
process a ScalarArrayOpExpr directly someday. We create base steps
only for OpExpr's for now.
> If you look at the rest of the rewritten comment, you'll notice some
> things probably need more explaining. Wording suggestions welcome.
When I looked at it earlier today, I thought your rewrite looked much better.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-04-06 15:46:26 | Re: [HACKERS] path toward faster partition pruning |
| Previous Message | Amit Langote | 2018-04-06 15:36:28 | Re: [HACKERS] path toward faster partition pruning |